[ovs-dev] [PATCH] lib: route-table improvements.

Ethan Jackson ethan at nicira.com
Tue Feb 1 06:45:19 UTC 2011


Oops, sorry about that.

btw your compiler seems to give better warnings than mine.  What
version/flags do you use?

Ethan

On Mon, Jan 31, 2011 at 6:58 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Sun, Jan 30, 2011 at 7:11 PM, Ethan Jackson <ethan at nicira.com> wrote:
>> This commit makes several changes to the route_table code used to
>> populate tunnel_egress_iface.
>>
>> - It removes name_table code from netdev-vport and puts it into
>>  route-table.
>>
>> - It no longer attempts to build the name_table dynamically by
>>  listening to rtnetlink-link notifications.  Instead it dumps the
>>  entire table, and uses rtnetlink-link notifications to indicate a
>>  re-dump is required.
>>
>> - It forces rtnetlink-link notifications to re-dump the routing
>>  table.  This fixes an issue where bringing an interface down or
>>  removing it all together would not have the expected effect on
>>  related tunnel_egress_ifaces.
>
> It looks like you have an off-by-one error:
>
> lib/route-table.c: In function ‘route_table_get_name’:
> lib/route-table.c:449: warning: array subscript is above array bounds
>




More information about the dev mailing list