[ovs-dev] [IPv6 IV: A New Hope 3/6] nicira-ext: Support matching ARP source and target hardware addresses.

Ben Pfaff blp at nicira.com
Tue Feb 1 19:53:35 UTC 2011

On Tue, Feb 01, 2011 at 12:53:50AM -0800, Justin Pettit wrote:
> OpenFlow 1.0 doesn't allow matching on the ARP source and target
> hardware address.  This has caused us to introduce hacks such as the
> Drop Spoofed ARP action.  Now that we have extensible match, we can
> match on more fields within ARP:
>     - Source Hardware Address (arp_sha)
>     - Target Hardware Address (arp_tha)
> Signed-off-by: Justin Pettit <jpettit at nicira.com>
> Acked-by: Jesse Gross <jesse at nicira.com>

Thanks for patiently updating this against master.  Dealing with
conflicts is a pain, I know.

In format_odp_key_attr(), I'm not sure that it makes sense to ever omit
the arp_sha and arp_tha from the output.  Even if they are zero, the
kernel is still matching against them (and so they really shouldn't be
zero, right?).

I'm not sure that you properly used tab indentation in datapath-protocol
(that file needs to be reindented anyway, but no sense in making it

Otherwise this looks fine to me, thank you.

More information about the dev mailing list