[ovs-dev] [IPv6 IV: A New Hope 5/6] nicira-ext: Support matching IPv6 traffic.

Ben Pfaff blp at nicira.com
Tue Feb 1 20:01:43 UTC 2011


In flow_from_nlattrs() here I think that there should be distinct cases
for IPv4 and IPv6, because presumably ICMPv4 wouldn't be inside IPv6 and
ICMPv6 wouldn't be inside IPv4:

> @@ -572,9 +688,11 @@ int flow_from_nlattrs(struct sw_flow_key *swkey, const struct nlattr *attr)
>  		return 0;
>  
>  	case ODP_KEY_ATTR_IPV4:
> +	case ODP_KEY_ATTR_IPV6:
>  		if (swkey->nw_proto == IPPROTO_TCP ||
>  		    swkey->nw_proto == IPPROTO_UDP ||
> -		    swkey->nw_proto == IPPROTO_ICMP)
> +		    swkey->nw_proto == IPPROTO_ICMP ||
> +		    swkey->nw_proto == IPPROTO_ICMPV6)
>  			return -EINVAL;
>  		return 0;
>  

Otherwise I only skimmed through this looking for differences from the
previous version and didn't see any other issues along the way.




More information about the dev mailing list