[ovs-dev] [PATCH 6/8] vswitchd: Implement Link Aggregation Control Protocol.

Ben Pfaff blp at nicira.com
Wed Feb 2 00:53:36 UTC 2011


On Tue, Feb 01, 2011 at 04:47:12PM -0800, Ethan Jackson wrote:
> > bond_run() is starting to have significant duplicate code in the two
> > cases. ?Should we add a helper function?
> 
> I wondered about that too.  I think its borderline  will go ahead and do it.
> 
> > Does anything ensure that a flow will be reevaluated if the new factors
> > added to is_admissible() could cause its admissibility to change?
> oooh good catch.  I think I added something like that in a later patch
> but I should pull it back here.  I think all I need to do is ofproto
> revalidate all of the interfaces in a bond whenever its LACP
> negotiation status changes.
> 
> > I see a couple of instances of 65335 (UINT16_MAX - 200) in vswitch.xml.
> > Are those typos for 65535 (UINT16_MAX)?
> Yep typos.

All of this sounds good to me, thanks.




More information about the dev mailing list