[ovs-dev] [PATCH 7/8] vswitchd: Implement balance-tcp bonding.

Ethan Jackson ethan at nicira.com
Wed Feb 2 03:02:38 UTC 2011

> Maybe we should put hash_symmetric_l4() and your new function in flow.c,
> since they seem to be generally interesting.

hash_symmetric_l4 is good for my purposes so I will just move it to
flow and use that.

> If you do keep the blacklisting approach for some reason then you can
> use struct assignment in place of memcpy in bond_hash_tcp().
> I don't see what difference the change to bond_send_learning_packets()
> makes.  It looks equivalent to me.

I had to initialize the flow before choose_output_iface so it can be
used in the hash.

> When no bond mode is explicitly set, would it make sense to default to
> balance-tcp if LACP negotiation succeeds?

Yes that's the plan.  Once QA has tested it I want to enable active
LACP on bonded ports by default, passive on non bonded ports, and set
the default bonding mode to balance-tcp.  Perhaps this is overly
conservative.  I can enable it by default here if you prefer.

More information about the dev mailing list