[ovs-dev] [IPv6 IV: A New Hope 6/6] nicira-ext: Support matching IPv6 Neighbor Discovery messages.

Ben Pfaff blp at nicira.com
Wed Feb 2 17:30:01 UTC 2011


On Tue, Feb 01, 2011 at 11:59:32PM -0800, Justin Pettit wrote:
> On Feb 1, 2011, at 10:54 PM, Ben Pfaff wrote:
> > I don't see a definition of nd_msg or nd_opt_hdr or related structures
> > anywhere.  I could easily be missing it, but if there aren't any then
> > I'd expect that we should add definitions to lib/packets.h so that we
> > can build on non-Linux hosts.  But if we're in a hurry that can wait.
> 
> "nd_msg" is only used in the kernel and defined in
> "include/net/ndisc.h" all the way back to 2.6.18.8.  The same is true
> of "nd_opt_hdr" in the kernel.  In userspace, "nd_opt_hdr" is defined
> in "/usr/include/netinet/icmp6.h".

OK, I see that you've got all your bases covered then.

The 2.6.18.8 bit worried me for a moment since we support 2.6.18 without
the .8 also, but I see from the Git history that nd_msg was there
already in 2.6.12-rc2.

> > How portable is <netinet/icmp6.h>?  I don't see it in POSIX...  Again
> > that could wait if we're in a hurry.
> 
> I think it's fairly portable.  It's described in RFC 2292 with the
> definitions we need, and I had verified that it exists on my Mac and
> NetBSD boxes.

Sounds fine, great.

> > Acked-by: Ben Pfaff <blp at nicira.com>
> 
> Thank you for the thorough review!  I'll wait for your acks on 3 and 5
> before I push.

I'm looking at them now.




More information about the dev mailing list