[ovs-dev] [PATCH 7/8] vswitchd: Implement balance-tcp bonding.

Ben Pfaff blp at nicira.com
Wed Feb 2 18:39:18 UTC 2011


On Tue, Feb 01, 2011 at 07:02:38PM -0800, Ethan Jackson wrote:
> > Maybe we should put hash_symmetric_l4() and your new function in flow.c,
> > since they seem to be generally interesting.
> 
> hash_symmetric_l4 is good for my purposes so I will just move it to
> flow and use that.

It's possibly adequate but it doesn't distinguish some flows that we
could in this case.

> > I don't see what difference the change to bond_send_learning_packets()
> > makes. ?It looks equivalent to me.
> 
> I had to initialize the flow before choose_output_iface so it can be
> used in the hash.

I see, thanks.

> > When no bond mode is explicitly set, would it make sense to default to
> > balance-tcp if LACP negotiation succeeds?
> 
> Yes that's the plan.  Once QA has tested it I want to enable active
> LACP on bonded ports by default, passive on non bonded ports, and set
> the default bonding mode to balance-tcp.  Perhaps this is overly
> conservative.  I can enable it by default here if you prefer.

Your choice make sense, thanks.




More information about the dev mailing list