[ovs-dev] [PATCH 7/8] vswitchd: Implement balance-tcp bonding.

Ben Pfaff blp at nicira.com
Wed Feb 2 21:10:08 UTC 2011

On Wed, Feb 02, 2011 at 12:50:35PM -0800, Ethan Jackson wrote:
> This commit implements a new bonding mode "balance-tcp" which takes
> into account L4 flow information when hashing.  If LACP negotiation
> is unsuccessful it automatically falls back to "balance-slb" bonding.
> Bug #4213.

I'm not sure that bond_send_learning_packets() actually makes any sense
for balance_tcp.  It doesn't make sense to try to force the remote
switch to learn a MAC address if that MAC can appear on more than one
link, as happens with balance_tcp.

Could you add a comment to bond_hash_tcp() that we don't actually depend
on the symmetry property here?

Otherwise looks good to me, thank you.

More information about the dev mailing list