[ovs-dev] [IPv6 IV: A New Hope 5/6] nicira-ext: Support matching IPv6 traffic.
jpettit at nicira.com
Wed Feb 2 21:27:01 UTC 2011
On Feb 2, 2011, at 11:21 AM, Justin Pettit wrote:
> On Feb 2, 2011, at 11:15 AM, Ben Pfaff wrote:
>> On Wed, Feb 02, 2011 at 11:12:36AM -0800, Justin Pettit wrote:
>>>> In odp_flow_key_to_flow(), I don't really like the mixing of IP_TYPE_*
>>>> (from packets.h) with IPPROTO_* (from some system header). I'd rather
>>>> add a IP_TYPE_ICMPV6 or use IPPROTO_* uniformly. Ditto in
>>>> parse_protocol() in ofp-parse.c.
>>> I agree and was planning to clean that up in a follow-on patch. Do
>>> you know why we define IP_TYPE_* in packets.h, if they're defined in
>>> "netinet/in.h"? I'd prefer to use the pre-defined ones and get rid of
>>> "IP_TYPE_*" from packets.h unless there's a compelling reason not to.
>> That's fine. I imagine that I didn't realize that IPPROTO_* was
>> portable at the time I defined IP_TYPE_*. The goal of packets.h was to
>> avoid dependencies on Linux kernel-specific macros and types. I guess I
>> was overzealous in this case, since those macros are specified by POSIX.
> That was my guess. I'll prepare a separate patch that switches to IPPROTO_*, which will then clean up those inconsistencies in the IPv6 patches that follow.
Okay, the entire codebase is consistently using IPPROTO_*, and I've pushed the IPv6 support to master. Thanks again for the reviews!
More information about the dev