[ovs-dev] [valgrind 2/2] daemon: Suppress valgrind warnings from read_pidfile().

Ben Pfaff blp at nicira.com
Thu Feb 3 22:57:03 UTC 2011


On Thu, Feb 03, 2011 at 02:14:34PM -0800, Jesse Gross wrote:
> On Tue, Feb 1, 2011 at 11:43 AM, Ben Pfaff <blp at nicira.com> wrote:
> > The version of valgrind I have in my test VMs doesn't know what F_GETLK
> > does, so it complains that l_pid is uninitialized even though fcntl sets
> > it. ?Initializing it ourselves before calling the function avoids a series
> > of false-positive warnings about use of uninitialized data.
> 
> Looks good.

Thanks, Jesse (and Justin).  I pushed out these two commits.




More information about the dev mailing list