[ovs-dev] [risc 0/3] Fix misaligned accesses on RISC machines

Justin Pettit jpettit at nicira.com
Fri Feb 4 02:06:34 UTC 2011


The series looks good to me.  When I compile it on my trusty Sun Blade 100, I see a dozen or so warnings of the type:

-=-=-=-=-=-=-=-=-=-=-=-
lib/ofp-print.c: In function 'ofp_print_nx_action':
lib/ofp-print.c:283: warning: cast increases required alignment of target type
lib/ofp-print.c:288: warning: cast increases required alignment of target type
lib/ofp-print.c: In function 'ofp_print_action':
lib/ofp-print.c:387: warning: cast increases required alignment of target type
lib/ofp-print.c:431: warning: cast increases required alignment of target type
lib/ofp-print.c:437: warning: cast increases required alignment of target type
lib/ofp-print.c:462: warning: cast increases required alignment of target type
-=-=-=-=-=-=-=-=-=-=-=-

Is this something to be concerned about?

--Justin


On Jan 18, 2011, at 11:58 AM, Ben Pfaff wrote:

> I ran the testsuite on Justin's trusty Sun Blade 100 and found
> the following problems.
> 
> Ben Pfaff (3):
>  Add types and accessors for working with half-aligned 64-bit values.
>  openflow: Use types and accessors for half-aligned 64-bit fields.
>  netlink: Use proper types and functions for half-aligned 64-bit
>    values.
> 
> build-aux/check-structs     |    1 +
> include/openflow/openflow.h |   55 +++++++++++++++++++++--------------------
> include/openvswitch/types.h |   25 ++++++++++++++++++-
> lib/netlink.c               |    9 ++++--
> lib/ofp-print.c             |   56 +++++++++++++++++++++++-------------------
> lib/unaligned.h             |   41 ++++++++++++++++++++++++++++++-
> ofproto/ofproto.c           |   47 +++++++++++++++++++-----------------
> 7 files changed, 155 insertions(+), 79 deletions(-)
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list