[ovs-dev] [PATCH] vswitchd: Process special packets more aggressively.

Ben Pfaff blp at nicira.com
Fri Feb 4 18:07:50 UTC 2011

On Thu, Feb 03, 2011 at 07:24:48PM -0800, Ethan Jackson wrote:
> Before this patch, special packets such as LACP and CFM messages
> were only processed if they had NORMAL open flow actions.  With
> this patch these messages are always processed unless originated in
> ofproto_send_packet().

I don't see a problem with the code, but I think that it could use
better documentation.  The skip_actions_cb member, in my opinion,
deserves a bigger comment explaining what the actions_cb is for and why
one would want to skip it.

I always find "negative" flags confusing, so I would consider renaming
skip_actions_cb as call_actions_cb and inverting the meaning.

The actions_cb only takes the actions and nf_output_iface parameters so
that it can set them to constants if and only if it returns false.  It
might be better to drop those parameters and have the caller take care
of those tasks if it returns false.

It just occurred to me that we still probably don't get some of these
packets up in the bridge if there is no flow at all.  I guess we could
still pass packets that miss in the flow table up to the actions hook
somehow?  Especially if we drop those "extra" parameters.

More information about the dev mailing list