[ovs-dev] [PATCH] vswitchd: Process special packets more aggressively.
blp at nicira.com
Fri Feb 4 19:22:58 UTC 2011
On Fri, Feb 04, 2011 at 11:18:31AM -0800, Ethan Jackson wrote:
> > The actions_cb only takes the actions and nf_output_iface parameters so
> > that it can set them to constants if and only if it returns false. ?It
> > might be better to drop those parameters and have the caller take care
> > of those tasks if it
> I thought about doing it this way briefly. I could imagine in the
> future having a use for being able to manipulate the actions list.
> For example, if the flow's action was to output on a bonded port, it
> could be replaced by an action to output on one of the slaves.
That's an interesting thought but the 'actions' argument here has
already been converted from OpenFlow actions into datapath actions, so
(unless we introduce datapath ports for bonds) we'd already have lost
that information at this point.
> At any rate, this kind of functionality would be easy to add later so
> I think it is clearer for now to simplify the callback and have false
> automatically clear the actions
> > It just occurred to me that we still probably don't get some of these
> > packets up in the bridge if there is no flow at all. ?I guess we could
> > still pass packets that miss in the flow table up to the actions hook
> > somehow? ?Especially if we drop those "extra" parameters.
> I will look into this.
More information about the dev