[ovs-dev] [PATCH] vswitchd: Deconfigure CFM when not configured.

Ben Pfaff blp at nicira.com
Fri Feb 4 19:26:21 UTC 2011


Thanks, I pushed this.

On Fri, Feb 04, 2011 at 11:23:41AM -0800, Ethan Jackson wrote:
> Looks Good.
> 
> On Fri, Feb 4, 2011 at 11:01 AM, Ben Pfaff <blp at nicira.com> wrote:
> > It looks to me like, once a CFM object is configured on an interface, it
> > will never get deconfigured. ? This fixes the problem.
> >
> > Found by inspection. ?I haven't tested the original code or the fix.
> > ---
> > ?vswitchd/bridge.c | ? ?2 ++
> > ?1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> > index bb67e17..f786108 100644
> > --- a/vswitchd/bridge.c
> > +++ b/vswitchd/bridge.c
> > @@ -5021,6 +5021,8 @@ iface_update_cfm(struct iface *iface)
> > ? ? mon = iface->cfg->monitor;
> >
> > ? ? if (!mon) {
> > + ? ? ? ?cfm_destroy(iface->cfm);
> > + ? ? ? ?iface->cfm = NULL;
> > ? ? ? ? return;
> > ? ? }
> >
> > --
> > 1.7.1
> >
> >




More information about the dev mailing list