[ovs-dev] [PATCH 2/2] tunneling: Always use skb->len for PMTUD.

Jesse Gross jesse at nicira.com
Fri Feb 4 23:07:29 UTC 2011


On Fri, Feb 4, 2011 at 2:48 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Feb 04, 2011 at 01:35:47PM -0800, Jesse Gross wrote:
>> Currently IPv4 uses the length of the packet in the IP header
>> and IPv6 uses actual length of the packet for path MTU discovery.
>> This changes both to use the length of the packet to be consistent
>> with each other and the the Linux IP stack and also to match what
>> actually causes fragmentation.
>>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> Acked-by: Ben Pfaff <blp at nicira.com>
>
> The formatting remains ugly, though.  Prettier version:
>
>        packet_length = skb->len - ETH_HLEN;
>        if (eth_hdr(skb)->h_proto == htons(ETH_P_8021Q))
>                packet_length -= VLAN_HLEN;

Yes, that's nicer.  I've made that change and pushed both of these patches.




More information about the dev mailing list