[ovs-dev] [PATCH 1/2] datapath: Don't use vlan_features before 2.6.26.

Jesse Gross jesse at nicira.com
Tue Feb 8 00:01:06 UTC 2011


Support for offloading over vlans wasn't introduced until 2.6.26,
so do full software emulation on kernels before that when dealing
with vlan packets.

Reported-by: Justin Pettit <jpettit at nicira.com>
Signed-off-by: Jesse Gross <jesse at nicira.com>
---
 datapath/vport-netdev.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c
index 21fa6a0..11faf8a 100644
--- a/datapath/vport-netdev.c
+++ b/datapath/vport-netdev.c
@@ -277,7 +277,11 @@ static int netdev_send(struct vport *vport, struct sk_buff *skb)
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37)
 	if (vlan_tx_tag_present(skb)) {
 		int err;
-		int features = skb->dev->features & skb->dev->vlan_features;
+		int features = 0;
+
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,26)
+		features = skb->dev->features & skb->dev->vlan_features;
+#endif
 
 		err = vswitch_skb_checksum_setup(skb);
 		if (unlikely(err)) {
-- 
1.7.1





More information about the dev mailing list