[ovs-dev] [PATCH] xenserver: Set fail_mode on internal bridges.

Justin Pettit jpettit at nicira.com
Wed Feb 9 07:47:03 UTC 2011


On Feb 8, 2011, at 11:05 PM, Ethan Jackson wrote:

>>> @@ -257,6 +285,7 @@ def main(argv):
>>>                 # so only check for "network-uuids" on creation.
>>>                 if name not in bridges:
>>>                     update_network_uuids(name, ids)
>>> +                    update_fail_mode(name)
>> 
>> I believe this will only get called on bridge creation.  Do you handle the case externally where the fail-mode is changed after the bridge is created?
> 
> No I don't.  I'm not sure what the requirements are on this, but my
> judgement is that we don't really need to handle that case.  The xapi
> fail mode setting will change very rarely so I think it's fine to
> require either a reboot, call of the update plugin, or hup of the
> script.  I can't think of a good way to do it otherwise without
> regularly polling xapi.

That's fair.  Thanks for fixing this!

--Justin






More information about the dev mailing list