[ovs-dev] [PATCH 4/4] xenserver: Don't require /etc/xensource-inventory at install.

Justin Pettit jpettit at nicira.com
Fri Feb 11 20:37:00 UTC 2011


On Feb 11, 2011, at 11:26 AM, Ben Pfaff wrote:

> On Fri, Feb 11, 2011 at 10:55:21AM -0800, Justin Pettit wrote:
>> From: Bob Ball <bob.ball at citrix.com>
>> 
>> There are two mechanisms of installing a supplemental pack ??? one is
>> after installation (using the xe-install-supplemental-pack command) and
>> one is during installation by either creating a new install ISO with the
>> supplemental pack bundled or creating an HTTP directory which serves the
>> install files and the new supplemental pack contents.
>> 
>> The RPM should support both methods, but currently only works if the
>> supplemental pack is installed post-installation.  The failure is caused
>> by /etc/xensource-inventory not existing during the installation; this
>> is created at the end of the installation, and therefore is not present
>> when the RPM is installed.  This cannot be used to determine the version
>> of the XenServer installation.
>> 
>> With this commit, /etc/xensource-inventory is not checked on
>> installation of XenServer.
>> 
>> Signed-off-by: Bob Ball <bob.ball at citrix.com>
> 
> I don't think that we ever need to source /etc/xensource-inventory
> anymore, but the rest of this makes sense to me.

Okay, I removed that and updated the commit description.  I've resent the patch series, since I've got to head out for a couple hour meeting, and I don't want to commit my changes until Andrew's committed his.  He's going to take care of pushing mine when he's done.

Oh, and thanks for the review!

--Justin







More information about the dev mailing list