[ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

[Ben Pfaff]

On Fri, Feb 11, 2011 at 12:37:43PM -0800, Ethan Jackson wrote:
> > I doubt it. ?Ethan?
> 
> I added the hashing-algorithm along with the following logic as part
> of the lacp changes.
> I'm pretty sure it's required, but if the logic pasted below isn't
> there it won't do anything.
> 
>     if mode == 'lacp':
>         argv += ['lacp=active']
> 
>         if halgo == 'src_mac':
>             argv += ['bond_mode=balance-slb']
>         elif halgo == "tcpudp_ports":
>             argv += ['bond_mode=balance-tcp']
>         else:
>             log("bridge %s has invalid bond-hashing-algorithm '%s'" %
> (bridge, halgo))
>             argv += ['bond_mode=balance-slb']
>     elif mode in ['balance-slb', 'active-backup']:
>         argv += ['lacp=off', 'bond_mode=%s' % mode]
>     else:
>         log("bridge %s has invalid bond-mode '%s'" % (bridge, mode))
>         argv += ['lacp=off', 'bond_mode=balance-slb']

The difference that I pointed out as unnecessary is in
InterfaceReconfigureBridge.py, which is only used when the Linux
bridge is in use.  The differences in InterfaceReconfigureVswitch.py
look correct to me.