[ovs-dev] [PATCH] xenserver: Replace customized xen-bugtool with plugin to collect qdisc info.

Ben Pfaff blp at nicira.com
Mon Feb 14 17:54:55 UTC 2011


On Fri, Feb 11, 2011 at 07:24:10PM -0800, Andrew Evans wrote:
> XenServer RPMs have installed a modified /usr/sbin/xen-bugtool that is
> identical to upstream except for an additional command to collect tc qdisc
> class configuration for each network interface. Since xen-bugtool has an
> extension mechanism, use that instead of maintaining a parallel patched
> xen-bugtool.
> 
> This does change the content of the bug report slightly. Instead of one file
> per network interface, qdisc class info for all interfaces is written to one
> file. This is an artifact of the xen-bugtool extension mechanism: a single
> extension command's output must go to one file, and it is impractical to create
> individual <command> tags for each interface dynamically.

We should add a license header to the new XML and shell scripts.  It's
annoying for trivial stuff, but when we don't do it people ask what
the license is.  (That even happened for a 1-line script!)

I'd suggest that they should have the same license as xen-bugtool:

<!--
 This library is free software; you can redistribute it and/or modify
 it under the terms of version 2.1 of the GNU Lesser General Public
 License as published by the Free Software Foundation.

 This library is distributed in the hope that it will be useful, but
 WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 Lesser General Public License for more details.

 You should have received a copy of the GNU Lesser General Public
 License along with this library; if not, write to the Free Software
 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
 USA.

 Copyright (C) 2011 Nicira Networks.
-->

and

# This library is free software; you can redistribute it and/or
# modify it under the terms of version 2.1 of the GNU Lesser General
# Public License as published by the Free Software Foundation.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
# USA
#
# Copyright (C) 2011 Nicira Networks.

Then you'll need to add those files to the list for LGPL 2.1 in
debian/copyright.in.

You could avoid the basename call in the script by writing the loop
as
	for iface in `cd /sys/class/net && echo *`; do

Would you mind writing /sbin/tc explicitly?  When I tested this script
the lack of /sbin in my $PATH was the only thing that prevented me
from running it as an ordinary user.

Thank you!




More information about the dev mailing list