[ovs-dev] [resubmit 1/4] ofproto: flow_stats_ds() print flows properly.
Ben Pfaff
blp at nicira.com
Mon Feb 14 23:28:40 UTC 2011
On Mon, Feb 14, 2011 at 02:05:58PM -0800, Ethan Jackson wrote:
> @@ -3668,6 +3668,7 @@ flow_stats_ds(struct ofproto *ofproto, struct rule *rule, struct ds *results)
> ds_put_format(results, "n_packets=%"PRIu64", ", packet_count);
> ds_put_format(results, "n_bytes=%"PRIu64", ", byte_count);
> cls_rule_format(&rule->cr, results);
> + ds_put_format(results, ",");
> if (act_len > 0) {
> ofp_print_actions(results, &rule->actions->header, act_len);
> } else {
Looks fine. Since it's a single character it would also be reasonable
to use ds_put_char().
More information about the dev
mailing list