[ovs-dev] [PATCH] ovsdb: Remove 'manager' column from 'Open vSwitch' table.

Ben Pfaff blp at nicira.com
Fri Feb 18 19:04:16 UTC 2011

On Fri, Feb 18, 2011 at 10:23:43AM -0800, Andrew Evans wrote:
> We had retained but deprecated the use of the older 'managers' column in the
> 'Open vSwitch' table for compatibility with applications that might still use
> it, but that created more problems than it solved. This commit removes the
> 'managers' column from the schema, and removes all references to it from the
> code, init scripts, documentation, and tests.

The following comment in bridge.c could use an update too:

    /* Collect all of the potential targets, as the union of the "managers"
     * column and the "targets" columns of the rows pointed to by
     * "manager_options", excluding any that are out-of-band. */

Otherwise this looks good to me.  Thank you!

More information about the dev mailing list