[ovs-dev] [coverity3 11/13] dhcp-client: Remove useless call to timeout() from send_reliably().
Ethan Jackson
ethan at nicira.com
Wed Feb 23 22:53:58 UTC 2011
Looks Good.
On Wed, Feb 23, 2011 at 1:24 PM, Ben Pfaff <blp at nicira.com> wrote:
> timeout() has no side effects so calling it without looking at the return
> value is pointless.
>
> Coverity #10700.
> ---
> lib/dhcp-client.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/lib/dhcp-client.c b/lib/dhcp-client.c
> index e59dc34..a0999bf 100644
> --- a/lib/dhcp-client.c
> +++ b/lib/dhcp-client.c
> @@ -894,7 +894,6 @@ send_reliably(struct dhclient *cli,
> do_send_msg(cli, &msg);
> cli->delay = MIN(cli->max_timeout, MAX(4, cli->delay * 2));
> cli->retransmit += fuzz(cli->delay, 1);
> - timeout(cli, cli->retransmit);
> dhcp_msg_uninit(&msg);
> }
> }
> --
> 1.7.2.3
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
>
More information about the dev
mailing list