[ovs-dev] [PATCH] datapath: Memset executed packet's fields using memset.
Jesse Gross
jesse at nicira.com
Thu Feb 24 04:07:50 UTC 2011
Currently we explicitly zero out each of the fields in the OVS_CB for
executed packets. However, it seems simpler and more robust to just
memset the whole thing to zero.
Signed-off-by: Jesse Gross <jesse at nicira.com>
---
datapath/datapath.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index dcff05f..84106b4 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -710,13 +710,7 @@ static int odp_packet_cmd_execute(struct sk_buff *skb, struct genl_info *info)
goto exit;
/* Initialize OVS_CB (it came from Netlink so might not be zeroed). */
- OVS_CB(packet)->vport = NULL;
- OVS_CB(packet)->flow = NULL;
- /* execute_actions() will reset tun_id to 0 anyhow. */
-#ifdef NEED_CSUM_NORMALIZE
- OVS_CB(packet)->ip_summed = OVS_CSUM_NONE;
-#endif
- vlan_copy_skb_tci(packet);
+ memset(packet->cb, 0, sizeof(struct ovs_skb_cb));
rcu_read_lock();
dp = get_dp(odp_header->dp_ifindex);
--
1.7.1
More information about the dev
mailing list