[ovs-dev] [PATCH 1/2] datapath: Don't free vport until all references are gone.

Jesse Gross jesse at nicira.com
Fri Feb 25 01:21:04 UTC 2011

On Thu, Feb 24, 2011 at 5:07 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Feb 24, 2011 at 04:23:06PM -0800, Jesse Gross wrote:
>> We currently call vport_free() for internal devices after the
>> device is unregistered.  This takes care of callers that use
>> either RTNL or RCU but not ones that have only a device reference.
>> In particular, if stats are requested while a datapath is being
>> unregistered we can try to use the vport data structures which
>> have already been freed.
>> Bug #4736
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
> I guess that you are talking about a stats request that comes through
> the network stack, not one that comes through the Open vSwitch userspace
> interface?  Good catch.  Thanks!

Yes, that's right.

> Acked-by: Ben Pfaff <blp at nicira.com>

Thanks, I pushed both of these patches.

More information about the dev mailing list