[ovs-dev] [tunnel hdr len: 1/1] datapath: compute header length only after options are set

Valient Gough valient at gmail.com
Fri Feb 25 06:04:31 UTC 2011

On Thu, Feb 24, 2011 at 8:25 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Thu, Feb 24, 2011 at 7:43 PM, Valient Gough <valient at gmail.com> wrote:
>> The call to tnl_ops->hdr_len should not occur before all options are setup.
>>  If the call happens earlier, then tunnels may end up using uninitialized
>> options.  This patch moves the hdr_len call after the output key setup.
> Thank you, this looks correct to me.  However, can you please include
> a Linux-style signed-off-by line and configure your mail client to
> send plain text messages (or use git-send-email)?

Sure, I'll resend.  I haven't used git before, so I may try pasting
format-patch output in text mode instead of using send-patch, so I can
see what is sent...

More information about the dev mailing list