[ovs-dev] [PATCH] xenserver: Add support for disabling in-band management via XAPI.

Ethan Jackson ethan at nicira.com
Mon Feb 28 23:17:37 UTC 2011


> +
> +        # Change bridge disable_in_band option if XAPI and OVS states differ.
> +        xapi_dib = network['other_config'].get('vswitch-disable-in-band')
> +        if not xapi_dib:
I think we should enumerate the valid possibilities here e.g.:
if xapi_dib not in ['true', 'false']:


> +    if network_rec:
> +        dib = network_rec['other_config'].get('vswitch-disable-in-band')
> +        if dib:
Same here.


> +def update_in_band_mgmt(name):
> +    rec = get_network_by_bridge(name)
> +
> +    if not rec:
> +        return
> +
> +    dib = rec['other_config'].get('vswitch-disable-in-band')
> +    if dib:

And here.

Otherwise looks good.  Go ahead and merge when you are ready.




More information about the dev mailing list