[ovs-dev] [bugfixes 1/3] dpif-linux: Always pass an actions attribute in dpif_flow_put().

Jesse Gross jesse at nicira.com
Tue Feb 1 02:51:46 UTC 2011


On Mon, Jan 31, 2011 at 4:48 PM, Ben Pfaff <blp at nicira.com> wrote:
> The kernel expects that ODP_FLOW_NEW always has an ODP_FLOW_ATTR_ACTIONS
> attribute, even though that attribute may be empty to drop all of the
> packets in the flow.  Similarly, ODP_FLOW_SET as used by
> dpif_linux_flow_put() should always have such an attribute, since it is
> used by OVS to update the flow's actions.  So make it possible for
> dpif_linux_flow_to_ofpbuf() to pass an empty actions attribute, and make
> dpif_linux_flow_put() always force that behavior if the actions_len passed
> to it is 0.
>
> This fixes EINVAL error creating flows to drop packets.

Acked-by: Jesse Gross <jesse at nicira.com>




More information about the dev mailing list