[ovs-dev] [PATCH 2/3] vswitchd: Fix segmentation fault with bonded ports.

Ethan Jackson ethan at nicira.com
Fri Jan 7 00:23:48 UTC 2011


This commit fixes a segmentation fault which could occur when a
bonded port was destroyed.
---
 vswitchd/bridge.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index e2d26c0..e977888 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -3717,6 +3717,9 @@ port_destroy(struct port *port)
         proc_net_compat_update_vlan(port->name, NULL, 0);
         proc_net_compat_update_bond(port->name, NULL);
 
+        netdev_monitor_destroy(port->monitor);
+        port->monitor = NULL;
+
         for (i = 0; i < MAX_MIRRORS; i++) {
             struct mirror *m = br->mirrors[i];
             if (m && m->out_port == port) {
@@ -3735,7 +3738,6 @@ port_destroy(struct port *port)
 
         VLOG_INFO("destroyed port %s on bridge %s", port->name, br->name);
 
-        netdev_monitor_destroy(port->monitor);
         free(port->ifaces);
         bitmap_free(port->trunks);
         free(port->name);
-- 
1.7.2





More information about the dev mailing list