[ovs-dev] [PATCH] bridge: Move tunnel_egress_iface to status column.
Ben Pfaff
blp at nicira.com
Fri Jan 7 17:25:39 UTC 2011
On Thu, Jan 06, 2011 at 07:58:28PM -0800, Ethan Jackson wrote:
> This commit removes the tunnel_egress_iface column from the
> interface table and moves it's data to the status column. In the
> process it reverts the database to version 1.0.0.
Thank you!
netdev_get_status() should return EOPNOTSUPP, not ENOTSUP, when the
provider doesn't implement the ->get_status() function.
The comments for netdev_get_status() and the ->get_status() function
should mention what kinds of information might be included. They should
probably point to ovs-vswitchd.conf.db(5). Otherwise anyone looking at
it will have no idea.
In iface_refresh_status() xmalloc() is better than xzalloc() since all
of the elements will be initialized immediately. Also I'd prefer to see
a helper function here analogous to shash_from_ovs_idl_map() but going
in the opposite direction.
If you update all that then please go ahead and push this.
More information about the dev
mailing list