[ovs-dev] [PATCH 3/3] vswitchd: Active backup bonding.

[Ben Pfaff]

On Thu, Jan 06, 2011 at 04:23:49PM -0800, Ethan Jackson wrote:
> This commit adds active backup bonding support to vswitchd.
> 
> Bug #4210.

Thank you for implementing this.  This looks good, but I have a few
comments:

choose_output_iface() should always add no_ifaces_tag if it cannot
successfully choose an output interfaces.

Also in choose_output_iface(), I'd just assert-fail if the bond type is
unknown.

In bond_unixctl_list() and bond_unixctl_show(), should we show the
bond's type?

The patch for the documentation for bond/migrate seemed to add a 1-space
indent to each line, why?

In vswitch.ovsschema, it would be better to enumerate all the allowed
settings, so that ovsdb-server can reject incorrect configurations, like
so:

       "bond_type": {
         "type": {"key": {"type": "string",
                          "enum": ["set", ["slb", "active-backup"]]},
                  "min": 0, "max": 1}},

Thanks,

Ben.