[ovs-dev] [netlink v3 11/16] shash: New "smap" functions for working with string-to-string maps.

Ben Pfaff blp at nicira.com
Mon Jan 10 01:28:40 UTC 2011


On Sun, Jan 9, 2011 at 5:01 PM, Justin Pettit <jpettit at nicira.com> wrote:
> I think it would be cleaner to just make this a new data structure, since it's a bit confusing to make some calls to to the same structure as "shash_" and others as "smap_".  I'd be especially concerned about how the "smap_" functions assume data will always be strings, but a careless user could easily introduce non-string data through the "shash_" functions.

Yeah, I tend to agree, in general.  I've been thinking along this direction for
a year or more.  At some point I think I'll get around to fully separating the
two data structures, but I hope that this is OK for temporary use.




More information about the dev mailing list