[ovs-dev] [PATCH] debian: Modify ovs-bugtool to include collectd rrd logs

[Ben Pfaff]

On Thu, Jan 13, 2011 at 09:17:44AM -0800, Sajjad Lateef wrote:
> collectd is a utility that stores rrd logs in the directory
> /var/lib/collectd/rrd/ by default. rrd logs are created when
> collectd is configured to output logs in Round Robin Database
> format.
> 
> With this change, ovs-bugtool will include collectd logs in the
> output bundle from /var/lib/collectd/rrd.  The output bundle will
> include all sub-directories of the specified collectd directory.
> 
> ovs-bugtool checks if a directory exists before it attempts to
> include the directory contents in the output bundle. So, running
> ovs-bugtool on a system that does not have collectd logs should
> not negatively affect the output of ovs-bugtool.

Thanks.  This looks good to me.  As long as you've tested it, you should
push it, after adding the following additional change:

diff --git a/AUTHORS b/AUTHORS
index c57d43b..183a8b3 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -23,6 +23,7 @@ Neil McKee              neil.mckee at inmon.com
 Paul Fazzone            pfazzone at nicira.com
 Reid Price              reid at nicira.com
 Romain Lenglet          romain.lenglet at berabera.info
+Sajjad Lateef           slateef at nicira.com
 Simon Horman            horms at verge.net.au
 Tetsuo NAKAGAWA         nakagawa at mxc.nes.nec.co.jp
 Thomas Lacroix          thomas.lacroix at citrix.com
@@ -64,7 +65,6 @@ Peter Balland           peter at nicira.com
 Ram Jothikumar          rjothikumar at nicira.com
 Rob Hoes                rob.hoes at citrix.com
 Roger Leigh             rleigh at codelibre.net
-Sajjad Lateef           slateef at nicira.com
 Sean Brady              sbrady at gtfservices.com
 Sebastian Andrzej Siewior  sebastian at breakpoint.cc
 Srini Seetharaman       seethara at stanford.edu