[ovs-dev] [PATCH] debian: Modify ovs-bugtool to include collectd rrd logs

[Sajjad Lateef]

On Thu, Jan 13, 2011 at 9:21 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Jan 13, 2011 at 09:17:44AM -0800, Sajjad Lateef wrote:
>> collectd is a utility that stores rrd logs in the directory
>> /var/lib/collectd/rrd/ by default. rrd logs are created when
>> collectd is configured to output logs in Round Robin Database
>> format.
>>
>> With this change, ovs-bugtool will include collectd logs in the
>> output bundle from /var/lib/collectd/rrd.  The output bundle will
>> include all sub-directories of the specified collectd directory.
>>
>> ovs-bugtool checks if a directory exists before it attempts to
>> include the directory contents in the output bundle. So, running
>> ovs-bugtool on a system that does not have collectd logs should
>> not negatively affect the output of ovs-bugtool.
>
> Thanks.  This looks good to me.  As long as you've tested it, you should
> push it, after adding the following additional change:

Done.

Tested successfully on both a machine that has collectd installed and
a machine where collected was *not* installed.

Sajjad

-- 
Sajjad Lateef
slateef at nicira.com