[ovs-dev] [netlink v4 05/52] netlink: New functions for finding a specific attribute.

Ben Pfaff blp at nicira.com
Thu Jan 13 20:36:47 UTC 2011


On Thu, Jan 13, 2011 at 11:35:42AM -0800, Justin Pettit wrote:
> Looks good.  Do you think it's worth noting that no validation of
> attribute lengths is done?  This seems particularly concerning for
> callers of nl_attr_find(), since it just points to a buffer.  Then
> again, maybe it's just "caveat caller", as they say in Latin America.

That's reasonable.  I added a comment.

> It's not part of this commit, but in the description of
> NL_ATTR_FOR_EACH_UNSAFE, "validates" should be "validated".

Thanks, I folded in this comment fix also.


Thank you for the review.




More information about the dev mailing list