[ovs-dev] [PATCH] netdev: Make 'netdev' parameter of 'get_features()' const since implementations shouldn't need to modify it.

Ben Pfaff blp at nicira.com
Mon Jan 17 23:33:13 UTC 2011


Looks good, except that the first line of the commit message is too
long.  Lines in commit messages should be limited to ~75 characters, and
the first paragraph should only be a single line.

e.g.:

    netdev: Make 'netdev' parameter of  'get_features()' const.

    Implementations shouldn't need to modify it.

See the "discussion" section of git-commit(1) and SubmittingPatches in
the OVS tree for more details.

Also, if this is the first commit that you push please add an update to
AUTHORS to it.

Thanks,

Ben.




More information about the dev mailing list