[ovs-dev] [netlink v4 40/52] datapath: Convert ODP_FLOW_* and ODP_EXECUTE to put dp_idx into message.

[Jesse Gross]

On Mon, Jan 17, 2011 at 4:25 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Jan 17, 2011 at 11:29:32AM -0800, Jesse Gross wrote:
>> Some bonus comments:
>>
>> On Tue, Jan 11, 2011 at 9:49 PM, Ben Pfaff <blp at nicira.com> wrote:
>> > +static int query_flow(struct odp_flow __user *uflow)
>> [...]
>> > + ? ? ? ? ? ? ? flow_node = tbl_lookup(dp->table, &flow.key, flow_hash(&key),
>> flow_cmp);
>>
>> This should use get_table_protected().
>
> Thanks, fixed.
>
>> > +static int dump_flow(struct datapath *dp, struct odp_flow_dump __user *udump)
>> [...]
>> > + ? ? ? tbl_node = tbl_next(dp->table, &dump.state[0], &dump.state[1]);
>>
>> Here too.
>
> Thanks, fixed.
>
>> > +static int compat_dump_flow(struct datapath *dp, struct compat_odp_flow_dump __user *udump)
>> [...]
>> > + ? ? ? tbl_node = tbl_next(dp->table, &dump.state[0], &dump.state[1]);
>>
>> And here as well.
>
> Thanks, fixed.
>
> I fixed up the ones that I introduced in fixes for the previous commit's
> comments, too.
>
> Here's the special bonus incremental diff versus the previous full diff
> that I just posted:

Looks good.