[ovs-dev] [netlink v4 43/52] datapath: Convert ODP_EXECUTE to use Netlink framing.

Jesse Gross jesse at nicira.com
Tue Jan 18 02:27:30 UTC 2011


On Tue, Jan 11, 2011 at 9:49 PM, Ben Pfaff <blp at nicira.com> wrote:
> diff --git a/include/openvswitch/datapath-protocol.h b/include/openvswitch/datapath-protocol.h
> index 69a4fc9..41a55eb 100644
> --- a/include/openvswitch/datapath-protocol.h
> +++ b/include/openvswitch/datapath-protocol.h
> @@ -92,7 +92,7 @@
>  #define ODP_FLOW_DUMP           _IOWR('O', 17, struct odp_flow)
>  #define ODP_FLOW_FLUSH          _IO('O', 19)
>
> -#define ODP_EXECUTE             _IOR('O', 18, struct odp_execute)
> +#define ODP_EXECUTE             _IOR('O', 18, struct odp_upcall)

I'm not sure that I understand the overlap between the upcalls and
execute.  Sure, both have packet data and sometimes actions but those
are just two attributes.  There quite a few attributes and the type
field that don't apply to execute.

However, the implementation itself looks good.




More information about the dev mailing list