[ovs-dev] [netlink v4 43/52] datapath: Convert ODP_EXECUTE to use Netlink framing.

[Ben Pfaff]

On Mon, Jan 17, 2011 at 6:27 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Tue, Jan 11, 2011 at 9:49 PM, Ben Pfaff <blp at nicira.com> wrote:
>> diff --git a/include/openvswitch/datapath-protocol.h b/include/openvswitch/datapath-protocol.h
>> index 69a4fc9..41a55eb 100644
>> --- a/include/openvswitch/datapath-protocol.h
>> +++ b/include/openvswitch/datapath-protocol.h
>> @@ -92,7 +92,7 @@
>>  #define ODP_FLOW_DUMP           _IOWR('O', 17, struct odp_flow)
>>  #define ODP_FLOW_FLUSH          _IO('O', 19)
>>
>> -#define ODP_EXECUTE             _IOR('O', 18, struct odp_execute)
>> +#define ODP_EXECUTE             _IOR('O', 18, struct odp_upcall)
>
> I'm not sure that I understand the overlap between the upcalls and
> execute.  Sure, both have packet data and sometimes actions but those
> are just two attributes.  There quite a few attributes and the type
> field that don't apply to execute.

It's true.  The alternative was to introduce a fifth family, but I was
feeling lazy and inconsistent.

If we're changing everything to use a single family anyway, there will
be even more attributes that won't apply.  That's a downside of using
a single family, but I don't know of a way to avoid it.