[ovs-dev] [PATCH 3/3] xenserver: Allow fail_mode to be set from xapi.

Ben Pfaff blp at nicira.com
Tue Jan 18 17:41:28 UTC 2011


On Mon, Jan 17, 2011 at 05:03:39PM -0800, Ethan Jackson wrote:
> This commit allows xapi to set the fail mode through the
> vswitch-controller-fail-mode other-config setting in the Pool
> object.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

This looks good to me.  The only thing that stands out to me is the
choice of strings "0" and "1" for Pool
other_config:vswitch-controller-fail-mode.  Is that cast in stone
somewhere?  Those seem like lousy choices, since there is no way to
guess what either value actually means without looking it up.

Thanks,

Ben.




More information about the dev mailing list