[ovs-dev] [IPv6 4/7] tests: Add test suite for packets.h.

Justin Pettit jpettit at nicira.com
Fri Jan 21 22:28:57 UTC 2011


On Jan 21, 2011, at 10:28 AM, Ben Pfaff wrote:

> On Fri, Jan 21, 2011 at 04:27:40AM -0800, Justin Pettit wrote:
>> This only tests ip_is_cidr(), since that is the only tricky function
>> currently defined.  This will get more use once IPv6 functions are
>> added.
> 
> Holy crap, someone wrote a new test!  Thank you very much.
> 
> Why does test-packets output a newline?  If you delete that, then you
> can change
>        AT_CHECK([test-packets], [0], [ignore])
> to
>        AT_CHECK([test-packets])
> since in fact that program should have no output.
> 
> Otherwise this looks good.


Okay, cleaned up.

Thanks,

--Justin






More information about the dev mailing list