[ovs-dev] [IPv6 Redux 3/6] nicira-ext: Support matching ARP source and target hardware addresses.

[Jesse Gross]

On Sat, Jan 22, 2011 at 1:06 PM, Justin Pettit <jpettit at nicira.com> wrote:
> On Jan 22, 2011, at 1:04 PM, Jesse Gross wrote:
>
>> On Sat, Jan 22, 2011 at 12:45 PM, Justin Pettit <jpettit at nicira.com> wrote:
>>> On Jan 22, 2011, at 11:33 AM, Jesse Gross wrote:
>>>
>>>>> +#define NXM_NX_ARP_SHA    NXM_HEADER  (0x0001, 17, 6)
>>>>> +#define NXM_NX_ARP_THA    NXM_HEADER  (0x0001, 18, 6)
>>>>
>>>> It seems like all of the other fields are eligible for being a source
>>>> for register move actions.  I don't think that it is particularly
>>>> interesting to do this for ARP but everything else appears to allow
>>>> it.
>>>
>>> I believe this is only a documentation error in the description of NXAST_REG_MOVE in "nicira-ext.h", right?  It looks like the code correctly implements it.  I also corrected this description in the future patches to reflect the ability to use NXM_NX_ICMPV6_TYPE,  NXM_NX_ICMPV6_CODE, NXM_NX_ND_SLL, and NXM_NX_ND_TLL as sources.  (The ability to use IPv6 addresses as a source is not currently supported.)
>>
>> I see some code to support register moving in
>> nx-match.c:nxm_read_field() that needs to know about the fields.
>
>
> Right, but I think it's handled:

Sorry, I was looking at the wrong branch when checking this.  My
fingers instinctively type 'netlink' as the branch with code to
review...