[ovs-dev] [netlink v4 13/52] odp-util: Improve formatting of bogus empty action attributes.

[Ethan Jackson]

Looks Good.

On Tue, Jan 11, 2011 at 9:49 PM, Ben Pfaff <blp at nicira.com> wrote:
> Before this change, these were formatted as:
>        ,***%u leftover bytes***
> After this change, they are formatted as:
>        <empty>,***%u leftover bytes***
> ---
>  lib/odp-util.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 29f536d..dc6843f 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2009, 2010 Nicira Networks.
> + * Copyright (c) 2009, 2010, 2011 Nicira Networks.
>  *
>  * Licensed under the Apache License, Version 2.0 (the "License");
>  * you may not use this file except in compliance with the License.
> @@ -187,6 +187,9 @@ format_odp_actions(struct ds *ds, const struct nlattr *actions,
>             format_odp_action(ds, a);
>         }
>         if (left) {
> +            if (left == actions_len) {
> +                ds_put_cstr(ds, "<empty>");
> +            }
>             ds_put_format(ds, " ***%u leftover bytes***", left);
>         }
>     } else {
> --
> 1.7.1
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
>