[ovs-dev] [netlink v4 10/52] netlink-socket: Make dumping and doing transactions on same nl_sock safe.

[Ben Pfaff]

On Sat, Jan 22, 2011 at 1:38 PM, Ethan Jackson <ethan at nicira.com> wrote:
> On Tue, Jan 11, 2011 at 9:49 PM, Ben Pfaff <blp at nicira.com> wrote:
>> It's not safe to use a single Netlink fd to do multiple operations in an
>> synchronous way.  Some of the limitations are fundamental; for example, the
> s/an/a
>
>> This commit also slightly simplifies netdev_vport_reset_name_else_route().
> This has ben renamed netdev_vport_reset_names().  FWIW I plan to
> remove all this stuff from netdev-vport in the near future (time
> permitting).

OK, thanks, I fixed up the commit message.

> +/* The client is attempting some operation on 'sock'.  If 'sock' has
> an ongoing
> + * dump operation, then replace 'sock''s fd by a new socket and hand
> 'sock''s
> + * old fd over to the dump. */
> s/by/with

OK, done.

> +        /* 'sock' might belong to some multicast group, or it already
> has an
> +         * onoging dump.  Clone the socket to avoid possibly
> intermixing
> s/onoging/ongoing
>
> Looks good.  Please push when you are ready.

Thank you for the review.