[ovs-dev] [PATCH] vswitchd: Fail the build when the schema checksum does not match.

Ben Pfaff blp at nicira.com
Mon Jan 24 20:05:23 UTC 2011


Before, a bad checksum was easy to miss because the build still succeeded.
With this change, a bad checksum makes the build fail.

This is what I thought the existing code already did, but I was wrong.

Suggested-by: Andrew Evans <aevans at nicira.com>
---
 vswitchd/automake.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/vswitchd/automake.mk b/vswitchd/automake.mk
index 87963fa..5c8ab3c 100644
--- a/vswitchd/automake.mk
+++ b/vswitchd/automake.mk
@@ -103,5 +103,6 @@ vswitchd/vswitch.ovsschema.stamp: vswitchd/vswitch.ovsschema
 	else \
 	  ln=`sed -n '/"cksum":/=' $?`; \
 	  echo "$?:$$ln: checksum \"$$sum\" does not match (you should probably update the version number and fix the checksum)"; \
+	  exit 1; \
 	fi
 CLEANFILES += vswitchd/vswitch.ovsschema.stamp
-- 
1.7.1





More information about the dev mailing list