[ovs-dev] [netlink v4 34/52] dpif: Eliminate "struct odp_flow_stats" from client-visible interface.

Ben Pfaff blp at nicira.com
Wed Jan 26 15:12:01 UTC 2011


On Wed, Jan 26, 2011 at 01:16:29AM -0800, Justin Pettit wrote:
> On Jan 11, 2011, at 9:49 PM, Ben Pfaff wrote:
> 
> > --- a/lib/dpif-netdev.c
> > +++ b/lib/dpif-netdev.c
> > @@ -111,7 +111,7 @@ struct dp_netdev_flow {
> >     struct flow key;
> > 
> >     /* Statistics. */
> > -    struct timespec used;       /* Last used time. */
> > +    long long int used;         /* Last used time. */
> 
> It might be nice to indicate the units of time.
> 
> Otherwise, looks good.

Thanks, I added a comment.




More information about the dev mailing list