[ovs-dev] [netlink v4 45/52] Eliminate ODPL_* from userspace-facing interface.

Ben Pfaff blp at nicira.com
Wed Jan 26 15:13:53 UTC 2011


On Wed, Jan 26, 2011 at 01:36:52AM -0800, Justin Pettit wrote:
> On Jan 11, 2011, at 9:49 PM, Ben Pfaff wrote:
> 
> > --- a/lib/dpif-linux.c
> > +++ b/lib/dpif-linux.c
> > @@ -775,7 +775,10 @@ parse_odp_upcall(struct ofpbuf *buf, struct dpif_upcall *upcall)
> >     }
> > 
> >     memset(upcall, 0, sizeof *upcall);
> > -    upcall->type = odp_upcall->type;
> > +    upcall->type = (odp_upcall->type == _ODPL_MISS_NR ? DPIF_UC_MISS
> > +                    : odp_upcall->type == _ODPL_ACTION_NR ? DPIF_UC_ACTION
> > +                    : odp_upcall->type == _ODPL_SFLOW_NR ? DPIF_UC_SAMPLE
> 
> Is there a reason not to just rename _ODPL_SFLOW_NR to _ODPL_SAMPLE_NR
> for consistency?

Not much reason to bother, all the _ODPL constants get renamed a little
late anyway.

Thank you for the review.




More information about the dev mailing list