[ovs-dev] [netlink v5 38/61] ofproto: Fix test for installability change when revalidating.
Ben Pfaff
blp at nicira.com
Thu Jan 27 00:23:21 UTC 2011
ctx.may_set_up_flow will become the new facet->may_install, so it's that
value that we should check instead of the current facet->may_install when
deciding whether to update the datapath flow.
Reviewed by Ethan Jackson <ethan at nicira.com>.
---
ofproto/ofproto.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index a0dca35..dd49225 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -2499,8 +2499,8 @@ facet_revalidate(struct ofproto *ofproto, struct facet *facet)
/* If the ODP actions changed or the installability changed, then we need
* to talk to the datapath. */
- if (actions_changed || facet->may_install != facet->installed) {
- if (facet->may_install) {
+ if (actions_changed || ctx.may_set_up_flow != facet->installed) {
+ if (ctx.may_set_up_flow) {
uint32_t keybuf[ODPUTIL_FLOW_KEY_U32S];
struct dpif_flow_stats stats;
struct ofpbuf key;
--
1.7.1
More information about the dev
mailing list