[ovs-dev] [netlink v5 56/61] datapath: Convert ODP_FLOW_* commands to use AF_NETLINK socket layer.

[Jesse Gross]

On Fri, Jan 28, 2011 at 2:08 PM, Ben Pfaff <blp at nicira.com> wrote:
> OK, here's the revert that I applied to "datapath: Convert ODP_DP_*
> commands to use AF_NETLINK socket layer":

OK.

> Here's the revert that I applied to "datapath: Convert ODP_VPORT_* to
> use AF_NETLINK socket layer":

OK.

> Here's the revert that I applied to "datapath: Convert ODP_FLOW_*
> commands to use AF_NETLINK socket layer":
>
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 34cbe71..8931456 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -1123,7 +1110,7 @@ static int odp_flow_cmd_del(struct sk_buff *skb, struct genl_info *info)
>                return -ENOENT;
>        flow = flow_cast(flow_node);
>
> -       reply = odp_flow_cmd_alloc_info(flow->sf_acts);
> +       reply = odp_flow_cmd_alloc_info(flow);
>        if (!reply)
>                return -ENOMEM;

I'm still not thrilled that this is inconsistent with the others in
terms of the extra optimization for flows but it really doesn't matter
that much.  All that I originally wanted to point out was the use
after free, which has been fixed now so let's go with this.

Acked-by: Jesse Gross <jesse at nicira.com>

I think that's everything.