[ovs-dev] [PATCH] datapath: Drop allocation of memory for ODP_PACKET_ATTR_TYPE.

Jesse Gross jesse at nicira.com
Sun Jan 30 19:42:59 UTC 2011


When doing an upcall we allocate memory for ODP_PACKET_ATTR_TYPE.
However, ODP_PACKET_ATTR_TYPE does not exist - the type is specified
by the command.

Signed-off-by: Jesse Gross <jesse at nicira.com>
---
 datapath/datapath.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/datapath/datapath.c b/datapath/datapath.c
index 544f8cd..89b0d7f 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -484,7 +484,6 @@ static int queue_control_packets(struct datapath *dp, struct sk_buff *skb,
 		skb->next = NULL;
 
 		len = sizeof(struct odp_header);
-		len += nla_total_size(4); /* ODP_PACKET_ATTR_TYPE. */
 		len += nla_total_size(skb->len);
 		len += nla_total_size(FLOW_BUFSIZE);
 		if (upcall_info->userdata)
-- 
1.7.1





More information about the dev mailing list